[
https://issues.apache.org/jira/browse/HBASE-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019635#comment-14019635
]
Hadoop QA commented on HBASE-4089:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648605/4089v3.txt
against trunk revision .
ATTACHMENT ID: 12648605
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 24 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String bcUrl = "http://hbase.apache.org/devapidocs/"; +
bc.getClass().getName().replaceAll("\\.", "/") + ".html";
+ <& bc_l1; bc = cacheConfig.getBlockCache().getBlockCaches() !=
null? cacheConfig.getBlockCache().getBlockCaches()[0]:
cacheConfig.getBlockCache(); &>
+ <& bc_l2; bc = cacheConfig.getBlockCache().getBlockCaches() !=
null && cacheConfig.getBlockCache().getBlockCaches().length > 1 ?
cacheConfig.getBlockCache().getBlockCaches()[1]: null; &>
+ bcl1Url = "http://hbase.apache.org/devapidocs/"; +
bcl1.getClass().getName().replaceAll("\\.", "/") + ".html";
+ bcl2Url = "http://hbase.apache.org/devapidocs/"; +
bcl2.getClass().getName().replaceAll("\\.", "/") + ".html";
+<p>See <a href="http://hbase.apache.org/book.html#block.cache";>Block Cache</a>
in the HBase Reference Guide for help.</p>
+ <td><%
StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictedCount())
%></td>
+ <td><%
StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getEvictionCount())
%></td>
+ <td><%
StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCount())
%></td>
+ <td><%
StringUtils.humanReadableInt(cacheConfig.getBlockCache().getStats().getHitCachingCount())
%></td>
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRSStatusServlet
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9702//console
This message is automatically generated.
> blockCache contents report
> --------------------------
>
> Key: HBASE-4089
> URL: https://issues.apache.org/jira/browse/HBASE-4089
> Project: HBase
> Issue Type: New Feature
> Reporter: Doug Meil
> Assignee: stack
> Attachments: 4089.wip.txt, 4089.wip.v2.txt, 4089v3.txt, bc_basic.png,
> bc_bucketcache.png, bc_buckets.png, bc_config.png, bc_l1.png,
> bc_l2_buckets.png, bc_showing_buckets_start.png, bc_slabs.png, bc_slabs.png,
> bc_stats.png, hbase_4089_blockcachereport.pdf,
> java_blockcache_checkpoint_2011_08_11.patch
>
>
> Summarized block-cache report for a RegionServer would be helpful. For
> example ...
> table1
> cf1 100 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
> cf2 200 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours
> table2
> cf1 75 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
> cf2 150 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours
> ... Etc.
> The current metrics list blockCacheSize and blockCacheFree, but there is no
> way to know what's in there. Any single block isn't really important, but
> the patterns of what CF/Table they came from, how big are they, and how long
> (on average) they've been in the cache, are important.
> No such interface exists in HRegionInterface. But I think it would be
> helpful from an operational perspective.
> Updated (7-29): Removing suggestion for UI. I would be happy just to get
> this report on a configured interval dumped to a log file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
