[
https://issues.apache.org/jira/browse/HBASE-4089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020178#comment-14020178
]
Andrew Purtell commented on HBASE-4089:
---------------------------------------
This is fantastic. I skimmed the jamon changes on RB and the attached snaps
look good.
IMO the line length warnings in the templates can be ignored.
Please check the javadoc warn isn't related to this change. Otherwise +1
The code changes are all on Private audience classes. CachedBlock is converted
from a class to an interface, but only affected code is all internal. Can we
have this in 0.98?
> blockCache contents report
> --------------------------
>
> Key: HBASE-4089
> URL: https://issues.apache.org/jira/browse/HBASE-4089
> Project: HBase
> Issue Type: New Feature
> Reporter: Doug Meil
> Assignee: stack
> Attachments: 4089.wip.txt, 4089.wip.v2.txt, 4089v3.txt, 4089v4.txt,
> bc_basic.png, bc_bucketcache.png, bc_buckets.png, bc_config.png, bc_l1.png,
> bc_l2_buckets.png, bc_showing_buckets_start.png, bc_slabs.png, bc_slabs.png,
> bc_stats.png, hbase_4089_blockcachereport.pdf,
> java_blockcache_checkpoint_2011_08_11.patch
>
>
> Summarized block-cache report for a RegionServer would be helpful. For
> example ...
> table1
> cf1 100 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
> cf2 200 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours
> table2
> cf1 75 blocks, totalBytes=yyyyy, averageTimeInCache=XXXX hours
> cf2 150 blocks, totalBytes=zzzzz, averageTimeInCache=XXXX hours
> ... Etc.
> The current metrics list blockCacheSize and blockCacheFree, but there is no
> way to know what's in there. Any single block isn't really important, but
> the patterns of what CF/Table they came from, how big are they, and how long
> (on average) they've been in the cache, are important.
> No such interface exists in HRegionInterface. But I think it would be
> helpful from an operational perspective.
> Updated (7-29): Removing suggestion for UI. I would be happy just to get
> this report on a configured interval dumped to a log file.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
