[
https://issues.apache.org/jira/browse/HBASE-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084505#comment-13084505
]
[email protected] commented on HBASE-4190:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1461/
-----------------------------------------------------------
(Updated 2011-08-13 01:08:04.852897)
Review request for hbase.
Changes
-------
Based on stack's comments and an offline discussion with Gary and Andy.
- pulled Coprocessor and CoprocessorEnvironment classes to root level, from
o.a.h.h.coprocessor to o.a.h.h.
- keep cp priority constants still in Coprocessor class.
- htd pattern related constants in HConstant
What do you think?
Summary
-------
Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
This addresses bug HBASE-4190.
https://issues.apache.org/jira/browse/HBASE-4190
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/Coprocessor.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/CoprocessorEnvironment.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/HConstants.java dda254d
src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java d835582
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
2fc8f39
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java
506051d
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
ec88a01
src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java 0290bf2
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
54ccd6f
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
18ba6e7
src/main/java/org/apache/hadoop/hbase/coprocessor/MasterCoprocessorEnvironment.java
5d8cf4c
src/main/java/org/apache/hadoop/hbase/coprocessor/ObserverContext.java
9349d5b
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment.java
da8076c
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java cfbb29d
src/main/java/org/apache/hadoop/hbase/coprocessor/WALCoprocessorEnvironment.java
6580c2c
src/main/java/org/apache/hadoop/hbase/coprocessor/WALObserver.java b086747
src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
c44da73
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
03df574
src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
a81ff84
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
36816e8
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
c85146a
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
0ab1339
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
6d31d70
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java
d9f6e5f
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java b4c407b
Diff: https://reviews.apache.org/r/1461/diff
Testing
-------
TestClassLoading passed locally.
Thanks,
Mingjie
> Coprocessors: pull up some cp constants from cp package to o.a.h.h.HConstants
> -----------------------------------------------------------------------------
>
> Key: HBASE-4190
> URL: https://issues.apache.org/jira/browse/HBASE-4190
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.90.4
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Priority: Minor
> Fix For: 0.90.5
>
>
> At HBase-3810, stack gave a comment after patch committed:
> > This is a bit odd where a class in the parent package has references to a
> > sub package.
> > Should these classes or at least their constants be pulled up to be at same
> > level as HTableD?
> Create a new jira where the constants will be pulled from
> o.a.h.h.regionserver.RegionCoprocessorHost to o.a.h.h.HConstants.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
