[
https://issues.apache.org/jira/browse/HBASE-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038322#comment-14038322
]
Anoop Sam John commented on HBASE-11363:
----------------------------------------
It would be better to do the AC check in preCompactScannerOpen hook Andy?
preCompact() hook is called after the scanner are open and heap is created. But
preCompactScannerOpen is called 1st. What do you say?
+1 for the removal of preCompactSelection() code.
> Access checks in preCompact and preCompactSelection are out of sync
> -------------------------------------------------------------------
>
> Key: HBASE-11363
> URL: https://issues.apache.org/jira/browse/HBASE-11363
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.3
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 0.98.4
>
> Attachments: HBASE-11363.patch
>
>
> As discussed on HBASE-6192, it looks like someone cut and pasted the access
> check from preCompact into preCompactSelection at one time and, later,
> another change was made that relaxed permissions for compaction requests from
> ADMIN to ADMIN|CREATE.
> We do not need an access check in preCompactSelection since a request to
> compact is already mediated by preCompact.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
