[
https://issues.apache.org/jira/browse/HBASE-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039628#comment-14039628
]
Anoop Sam John commented on HBASE-11363:
----------------------------------------
bq.Checking in both preCompactScannerOpen and preCompact would be redundant
I mean move from preCompact to preCompactScannerOpen as it is early out.
bq. So is the patch on this issue good enough for now
Surely. This solves the issue with out of sync checks. +1
You can commit. NP.
> Access checks in preCompact and preCompactSelection are out of sync
> -------------------------------------------------------------------
>
> Key: HBASE-11363
> URL: https://issues.apache.org/jira/browse/HBASE-11363
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.3
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 0.98.4
>
> Attachments: HBASE-11363.patch
>
>
> As discussed on HBASE-6192, it looks like someone cut and pasted the access
> check from preCompact into preCompactSelection at one time and, later,
> another change was made that relaxed permissions for compaction requests from
> ADMIN to ADMIN|CREATE.
> We do not need an access check in preCompactSelection since a request to
> compact is already mediated by preCompact.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
