[
https://issues.apache.org/jira/browse/HBASE-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057939#comment-14057939
]
Andrew Purtell commented on HBASE-11039:
----------------------------------------
Thanks for updating the class Javadoc.
Just about there I think.
{quote}
estContinuousIngest(org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList):
org/jboss/netty/channel/ChannelFactory
I am getting this error in the trunk while trying to run this
{quote}
Yeah. I see you opened HBASE-11489 for that. Let's get this test working in
0.98, and commit the changes that let that happen through trunk, and fix the
Netty related issue on HBASE-11489.
bq. If both VC and ACL are not configured in the site.xml then we may get
errors as ACL table would not be available.
Yes, in this part:
{code}
+ private void createTable(HBaseAdmin admin, TableName tableName, boolean
setVersion)
+ throws IOException {
+ if (!admin.tableExists(tableName)) {
+ HTableDescriptor htd = new HTableDescriptor(tableName);
+ HColumnDescriptor family = new HColumnDescriptor(FAMILY_NAME);
+ if (setVersion) {
+ family.setMaxVersions(DEFAULT_TABLES_COUNT);
+ }
+ htd.addFamily(family);
+ admin.createTable(htd);
+ LOG.info("Granting permissions for user " + USER.getShortName());
+ AccessControlProtos.Permission.Action[] actions = {
AccessControlProtos.Permission.Action.READ };
+ try {
+ AccessControlClient.grant(getConf(), tableName, USER.getShortName(),
null, null, actions);
+ } catch (Throwable e) {
+ LOG.fatal("Error in granting permission for the user " +
USER.getShortName(), e);
+ throw new IOException(e);
+ }
+ }
+ }
{code}
Please consider adding a method 'boolean
AccessControlClient#isAccessControllerRunning' that returns true if the AC is
installed and active, false otherwise. Check the return value of the new method
first before attempting any grant. Then we should be ok.
> [VisibilityController] Integration test for labeled data set mixing and
> filtered excise
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-11039
> URL: https://issues.apache.org/jira/browse/HBASE-11039
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.98.1
> Reporter: Andrew Purtell
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.99.0, 1.0.0, 0.98.4
>
> Attachments: HBASE-11039_ITBLL_v1.patch, HBASE-11039_v3_0.98.patch
>
>
> Create an integration test for the VisibilityController that:
> 1. Create several tables of test data
> 2. Assign a set of auths to each table. Label all entries in the table with
> appropriate visibility expressions. Insure that some data in every table
> overlaps with data in other tables at common row/family/qualifier
> coordinates. Generate data like ITBLL so we can verify all data present later.
> 3. Mix the data from the different tables into a new common table
> 4. Verify for each set of auths defined in step #2 that all entries found in
> the source table can be found in the common table. Like the ITBLL
> verification step but done N times for each set of auths defined in step #2.
> 5. Choose one of the source tables. Get its set of auths. Perform a deletion
> with visibility expression from the common table using those auths.
> 6. Verify that no data in the common table with the auth set chosen in #5
> remains. A simple row count with the set of auths chosen in #5 that should
> return 0.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
