[
https://issues.apache.org/jira/browse/HBASE-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061300#comment-14061300
]
Andrew Purtell commented on HBASE-11514:
----------------------------------------
+1 on v2 patch. Although, suggest a separate change for this:
{noformat}
diff --git a/pom.xml b/pom.xml
index bb76f5c..1a27b0f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -938,7 +938,7 @@
<maven.assembly.version>2.4</maven.assembly.version>
<maven.antrun.version>1.6</maven.antrun.version>
<jamon.plugin.version>2.3.4</jamon.plugin.version>
- <findbugs-maven-plugin.version>2.5.2</findbugs-maven-plugin.version>
+ <findbugs-maven-plugin.version>2.5.4</findbugs-maven-plugin.version>
<findbugs-annotations>1.3.9-1</findbugs-annotations>
<maven.site.version>3.3</maven.site.version>
<javadoc.version>2.9</javadoc.version>
{noformat}
> Fix findbugs warnings in blockcache
> -----------------------------------
>
> Key: HBASE-11514
> URL: https://issues.apache.org/jira/browse/HBASE-11514
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 1.0.0
>
> Attachments: 10930.txt, 10930v2.txt
>
>
> Fixing a few findbugs issues around blockcache. Adding equals when we have
> compareTo. Noticed that hbase.bucketcache.percentage.in.combinedcache is NOT
> used anywhere though we doc it as working. Rather than implement, I'm
> removing it. Makes config of cache cleaner (do the L1 and then do the L2
> independent of each other rather than have independent config and then this
> odd hbase.bucketcache.percentage.in.combinedcache that spans them).
> Changed the package doc to remove reference to
> hbase.bucketcache.percentage.in.combinedcache (did an edit too removing
> slabcache mentions in package-info).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
