[ 
https://issues.apache.org/jira/browse/HBASE-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061638#comment-14061638
 ] 

Hadoop QA commented on HBASE-11514:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12655674/10930v3.txt
  against trunk revision .
  ATTACHMENT ID: 12655674

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.client.TestReplicaWithCluster.testCreateDeleteTable(TestReplicaWithCluster.java:138)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10065//console

This message is automatically generated.

> Fix findbugs warnings in blockcache
> -----------------------------------
>
>                 Key: HBASE-11514
>                 URL: https://issues.apache.org/jira/browse/HBASE-11514
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 10930.txt, 10930v2.txt, 10930v3.txt, 10930v3.txt
>
>
> Fixing a few findbugs issues around blockcache.  Adding equals when we have 
> compareTo.  Noticed that hbase.bucketcache.percentage.in.combinedcache is NOT 
> used anywhere though we doc it as working.   Rather than implement, I'm 
> removing it.  Makes config of cache cleaner (do the L1 and then do the L2 
> independent of each other rather than have independent config and then this 
> odd hbase.bucketcache.percentage.in.combinedcache that spans them).
> Changed the package doc to remove reference to 
> hbase.bucketcache.percentage.in.combinedcache (did an edit too removing 
> slabcache mentions in package-info).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to