[
https://issues.apache.org/jira/browse/HBASE-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063161#comment-14063161
]
Anoop Sam John commented on HBASE-11520:
----------------------------------------
+1. Looks great!
bq.The L1 LruBlockCache will be whatever hfile.block.cache.size is set to and
the L2 BucketCache will be whatever hbase.bucketcache.size is set to.
Great! I was also thinking of changing this area and making things simple.
{code}
+ float bucketCachePercentage = c.getFloat(BUCKET_CACHE_SIZE_KEY, 0F);
+ long bucketCacheSize = (long) (bucketCachePercentage < 1? mu.getMax() *
bucketCachePercentage:
+ bucketCachePercentage * 1024 * 1024);
{code}
When bucketCacheIOEngineName is "heap" it is correct to calculate the memory
size by mu.getMax() * bucketCachePercentage
But when it is offheap, size calculation based on max heap memory looks strange
no?
Also some more work I will do later to make CombinedBlockCache as resizable.
On resize the L1 can be resized. After this goes in will do.
> Simplify offheap cache config by removing the confusing
> "hbase.bucketcache.percentage.in.combinedcache"
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-11520
> URL: https://issues.apache.org/jira/browse/HBASE-11520
> Project: HBase
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.99.0
> Reporter: stack
> Assignee: stack
> Fix For: 0.99.0, 2.0.0
>
> Attachments: 11520.txt, 11520v2.txt, 11520v3.txt, 11520v3.txt
>
>
> Remove "hbase.bucketcache.percentage.in.combinedcache". It is unnecessary
> complication of block cache config. Let L1 config setup be as it is whether
> a L2 present or not, just set hfile.block.cache.size (not
> hbase.bucketcache.size * (1.0 -
> hbase.bucketcache.percentage.in.combinedcache)). For L2, let
> hbase.bucketcache.size be the actual size of the bucket cache, not
> hbase.bucketcache.size * hbase.bucketcache.percentage.in.combinedcache.
> Attached patch removes the config. and updates docs. Adds tests to confirm
> configs are as expected whether a CombinedBlockCache deploy or a strict L1+L2
> deploy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
