[
https://issues.apache.org/jira/browse/HBASE-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063204#comment-14063204
]
stack commented on HBASE-11520:
-------------------------------
bq. When bucketCacheIOEngineName is "heap" it is correct to calculate the
memory size by mu.getMax() * bucketCachePercentage But when it is offheap,
size calculation based on max heap memory looks strange no?
Yeah. It is fallout from the way in which BUCKET_CACHE_SIZE_KEY can be either
MB or a float between 0 and 1. I am reluctant to change this for 1.0. Someone
may be depending on this 'behavior'. I intend to add more on BC to refguide
describing options. Will include doc on this little vagary.
Resizeable CBC would be great though I'd say resizing an offheap BC is probably
low priority; the important resizing is in the heap and you have the LruBC
doing that already.
Thanks for the +1. Let me commit. The TestReplicaWithCluster is unrelated.
> Simplify offheap cache config by removing the confusing
> "hbase.bucketcache.percentage.in.combinedcache"
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-11520
> URL: https://issues.apache.org/jira/browse/HBASE-11520
> Project: HBase
> Issue Type: Sub-task
> Components: io
> Affects Versions: 0.99.0
> Reporter: stack
> Assignee: stack
> Fix For: 0.99.0, 2.0.0
>
> Attachments: 11520.txt, 11520v2.txt, 11520v3.txt, 11520v3.txt
>
>
> Remove "hbase.bucketcache.percentage.in.combinedcache". It is unnecessary
> complication of block cache config. Let L1 config setup be as it is whether
> a L2 present or not, just set hfile.block.cache.size (not
> hbase.bucketcache.size * (1.0 -
> hbase.bucketcache.percentage.in.combinedcache)). For L2, let
> hbase.bucketcache.size be the actual size of the bucket cache, not
> hbase.bucketcache.size * hbase.bucketcache.percentage.in.combinedcache.
> Attached patch removes the config. and updates docs. Adds tests to confirm
> configs are as expected whether a CombinedBlockCache deploy or a strict L1+L2
> deploy.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
