[
https://issues.apache.org/jira/browse/HBASE-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071105#comment-14071105
]
stack commented on HBASE-11551:
-------------------------------
Is this a real issue? Was it encountered running a test? What is this patch
supposed to do? There already is an outer catch. This patch adds a new inner
try/catch that does nothing but catch an IOE, logs and just keeps going? The
previous author thought the thread should die. Why does the current author
think it should not?
> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
> Key: HBASE-11551
> URL: https://issues.apache.org/jira/browse/HBASE-11551
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.99.0, 2.0.0
>
> Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
> try {
> while (cacheEnabled && writerEnabled) {
> ...
> } catch (Throwable t) {
> LOG.warn("Failed doing drain", t);
> }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method would
> terminate, silently.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
