[ 
https://issues.apache.org/jira/browse/HBASE-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071397#comment-14071397
 ] 

chunhui shen commented on HBASE-11551:
--------------------------------------

The above exception ‘Failed allocating for block bck2_0’ won't cause 
writerThread exiting.

bq. if you talked to the fellow whose filesystem just overflowed with unnoticed 
ERROR logs because of some non-self-healing issue
If the caught exception is self-healing or occasional, the changes will make 
sense.

Just now, we haven't encountered such exception. It is make-work code reading 
for me.


> BucketCache$WriterThread.run() doesn't handle exceptions correctly
> ------------------------------------------------------------------
>
>                 Key: HBASE-11551
>                 URL: https://issues.apache.org/jira/browse/HBASE-11551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11551-v1.txt
>
>
> Currently the catch is outside the while loop:
> {code}
>       try {
>         while (cacheEnabled && writerEnabled) {
> ...
>       } catch (Throwable t) {
>         LOG.warn("Failed doing drain", t);
>       }
> {code}
> When exception (e.g. BucketAllocatorException) is thrown, run() method would 
> terminate, silently.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to