[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088691#comment-13088691
]
Ted Yu commented on HBASE-4213:
-------------------------------
{code}
+ boolean currentBalanceSwitch = master.isBalancerEnabaled();
+ if (this.master.isBalancerEnabaled()) {
+ LOG.info("Load Balancer enabled. Disabling load balancer for " +
+ "instant schema change");
+ this.master.balanceSwitch(false);
+ }
{code}
I think there is no need to introduce a new method. master.balanceSwitch()
returns the old value which can be stored in currentBalanceSwitch.
{code}
+ while(true) {
+ if (!masterSchemaChangeTracker.isSchemaChangeNodeExists(
+ Bytes.toString(tableName))) {
+ break;
+ }
+ }
{code}
Should we introduce fault tolerance logic in the above loop ? E.g. if a region
server goes down and thus would not acknowledge completion of the schema change.
> Support instant schema updates with out master's intervention (i.e with out
> enable/disable and bulk assign/unassign)
> --------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4213
> URL: https://issues.apache.org/jira/browse/HBASE-4213
> Project: HBase
> Issue Type: Improvement
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Fix For: 0.92.0
>
> Attachments: HBASE-4213-Instant_schema_change.patch,
> HBASE-4213_Instant_schema_change_-Version_2_.patch,
> HBASE_Instant_schema_change-version_3_.patch
>
>
> This Jira is a slight variation in approach to what is being done as part of
> https://issues.apache.org/jira/browse/HBASE-1730
> Support instant schema updates such as Modify Table, Add Column, Modify
> Column operations:
> 1. With out enable/disabling the table.
> 2. With out bulk unassign/assign of regions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
