[
https://issues.apache.org/jira/browse/HBASE-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088234#comment-14088234
]
Nick Dimiduk commented on HBASE-11678:
--------------------------------------
patch v2:
{noformat}
+ "; adjust BucketCache sizes " + CacheConfig.BUCKET_CACHE_BUCKETS_KEY +
+ " to accomodate if size seems reasonable and you want it cached.");
{noformat}
Nice, I like it.
{noformat}
+ private volatile boolean writerEnabled = true;
{noformat}
Why mark this volatile?
{noformat}
- if (cacheEnabled
- && (now - ioErrorStartTime) > this.ioErrorsTolerationDuration) {
- LOG.error("IO errors duration time has exceeded "
- + ioErrorsTolerationDuration
- + "ms, disabing cache, please check your IOEngine");
+ if (cacheEnabled && (now - ioErrorStartTime) >
this.ioErrorsTolerationDuration) {
+ LOG.error("IO errors duration time has exceeded " +
ioErrorsTolerationDuration +
+ "ms, disabing cache, please check your IOEngine");
disableCache();
{noformat}
I know there's no new functionality here, but shouldn't this be an RS-abort
kind of offense?
{noformat}
+ this.bc = new BucketCache("heap", capacity, 1, new int [] {1},
writerThreadsCount,
{noformat}
nit: isn't "heap" and friends in an Enum somewhere? ... Oh, there's not.
Probably should be.
Nice new tests. Are you able to verify that testTooBigEntry fails on current
master? Maybe too much refactoring is necessary to confirm.
+1
> BucketCache ramCache fills heap after running a few hours
> ---------------------------------------------------------
>
> Key: HBASE-11678
> URL: https://issues.apache.org/jira/browse/HBASE-11678
> Project: HBase
> Issue Type: Bug
> Components: BlockCache
> Affects Versions: 0.99.0, 0.98.5, 2.0.0
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.99.0, 2.0.0, 0.98.6
>
> Attachments:
> 0001-When-we-failed-add-an-entry-failing-with-a-CacheFull.patch, 11678v2.txt,
> gc_over_12_hours_unevenblocks_with_lots_of_evictions.png
>
>
> Testing BucketCache, my heap filled after running for hours. Dumping heap,
> culprit is the ramCache Map in BucketCache. Tried running with more writer
> threads but made no difference. Trying to figure now how our accounting is
> going wonky.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
