[
https://issues.apache.org/jira/browse/HBASE-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088298#comment-14088298
]
stack commented on HBASE-11678:
-------------------------------
bq. Why mark this volatile?
Otherwise test was flakey.
bq. I know there's no new functionality here, but shouldn't this be an RS-abort
kind of offense?
It could be. The current behavior where it tries to muddle through w/o an L2
blockcache could be better in most cases (lightly loaded, serve from fscache
rather than L2 cache w/ degraded perf).
bq. Nice new tests. Are you able to verify that testTooBigEntry fails on
current master? Maybe too much refactoring is necessary to confirm.
That'd have been nice.
Let me post the ugly GC graph pre-patch as substitute.
Thanks for review [~ndimiduk]
> BucketCache ramCache fills heap after running a few hours
> ---------------------------------------------------------
>
> Key: HBASE-11678
> URL: https://issues.apache.org/jira/browse/HBASE-11678
> Project: HBase
> Issue Type: Bug
> Components: BlockCache
> Affects Versions: 0.99.0, 0.98.5, 2.0.0
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 0.99.0, 2.0.0, 0.98.6
>
> Attachments:
> 0001-When-we-failed-add-an-entry-failing-with-a-CacheFull.patch, 11678v2.txt,
> gc_over_12_hours_unevenblocks_with_lots_of_evictions.png
>
>
> Testing BucketCache, my heap filled after running for hours. Dumping heap,
> culprit is the ramCache Map in BucketCache. Tried running with more writer
> threads but made no difference. Trying to figure now how our accounting is
> going wonky.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
