[
https://issues.apache.org/jira/browse/HBASE-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097185#comment-14097185
]
Andrew Purtell commented on HBASE-11733:
----------------------------------------
I tend to agree with Matteo that the maintainability improvement is really big
here. The copy-paste wasn't bad in the beginning but the pre/post-amble of
coprocessor hook invocations has grown over time, and inconsistently (bad)
Use of reflection will cost us more than an additional object allocation,
guaranteed.
Thanks for the 0.98 patch. +1 for 0.98 and up
> Avoid copy-paste in Master/Region CoprocessorHost
> -------------------------------------------------
>
> Key: HBASE-11733
> URL: https://issues.apache.org/jira/browse/HBASE-11733
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-11733-0.98-v1.patch, HBASE-11733-v0.patch
>
>
> all the methods of MasterCoprocessorHost and RegionCoprocessorHost are
> copy-paste, and a couple of them have some missing fixes.
> The body of each function is the same, the only difference is the call to the
> specific coprocessor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
