[ 
https://issues.apache.org/jira/browse/HBASE-11733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097873#comment-14097873
 ] 

Gary Helmling commented on HBASE-11733:
---------------------------------------

In the initial coprocessor development, we were hesitant to do something 
similar and introduce any additional overhead in hot code paths.  But I agree 
that the current code has grown unmaintainable, and this would be a really nice 
clean up to have.

If we can show there is no significant impact on performance or GC, then a big 
+1.  Do you have any sense of the difference in young gen GC pre and post 
change?

> Avoid copy-paste in Master/Region CoprocessorHost
> -------------------------------------------------
>
>                 Key: HBASE-11733
>                 URL: https://issues.apache.org/jira/browse/HBASE-11733
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11733-0.98-v1.patch, HBASE-11733-v0.patch
>
>
> all the methods of MasterCoprocessorHost and RegionCoprocessorHost are 
> copy-paste, and a couple of them have some missing fixes.
> The body of each function is the same, the only difference is the call to the 
> specific coprocessor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to