[ 
https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090990#comment-13090990
 ] 

Akash Ashok commented on HBASE-4247:
------------------------------------

Firstly in the process of working on this. I have made the following assumptions

1. if abort() has a null implementation, then 
      a. isAborted() will have a null implementation ( returns false )

2. if abort() throws a RuntimeException(), then 
      a. create a boolean abort 
      b.set this to true in  abort()
      c. return abort in isAbort()

I hope this would be fine.


Secondly there are Instances where in abort() implementation this.stopped and 
this.closed are manipulated. Shouldn't this be done in stop() and close() 
methods of Stoppable and Closable interfaces? This is a little misleading isn't 
it ? 

If it really has to be stopped when aborted then why not call stop() from 
abort(). I feel it makes it more meaningful



> Add isAborted method to the Abortable interface
> -----------------------------------------------
>
>                 Key: HBASE-4247
>                 URL: https://issues.apache.org/jira/browse/HBASE-4247
>             Project: HBase
>          Issue Type: Task
>            Reporter: Akash Ashok
>            Assignee: Akash Ashok
>            Priority: Minor
>
> Add a new method isAborted() to the Abortable interface 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to