[
https://issues.apache.org/jira/browse/HBASE-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092492#comment-13092492
]
Akash Ashok commented on HBASE-4247:
------------------------------------
TestMerge tool is failing because of the changes I made I am sure.
The change is basically this:
Original
<code>
@Override
public void abort(final String msg, Throwable t) {
if (t instanceof KeeperException.SessionExpiredException) {
try {
LOG.info("This client just lost it's session with ZooKeeper, trying" +
" to reconnect.");
resetZooKeeperTrackers();
LOG.info("Reconnected successfully. This disconnect could have been" +
" caused by a network partition or a long-running GC pause," +
" either way it's recommended that you verify your environment.");
return;
} catch (ZooKeeperConnectionException e) {
LOG.error("Could not reconnect to ZooKeeper after session" +
" expiration, aborting");
t = e;
}
}
if (t != null) LOG.fatal(msg, t);
else LOG.fatal(msg);
this.closed=true;
}
</code>
Changed
<code>
@Override
public void abort(final String msg, Throwable t) {
if (t instanceof KeeperException.SessionExpiredException) {
try {
LOG.info("This client just lost it's session with ZooKeeper, trying" +
" to reconnect.");
resetZooKeeperTrackers();
LOG.info("Reconnected successfully. This disconnect could have been" +
" caused by a network partition or a long-running GC pause," +
" either way it's recommended that you verify your environment.");
return;
} catch (ZooKeeperConnectionException e) {
LOG.error("Could not reconnect to ZooKeeper after session" +
" expiration, aborting");
t = e;
}
}
if (t != null) LOG.fatal(msg, t);
else LOG.fatal(msg);
close(false);
}
</code>
My question is close is closing zookeeper session and other thing. But does
changing this leads to other test cases like TestMergeTool failing.
Does setting this.closed=true have any meaning at all in abort without actually
closing ?
> Add isAborted method to the Abortable interface
> -----------------------------------------------
>
> Key: HBASE-4247
> URL: https://issues.apache.org/jira/browse/HBASE-4247
> Project: HBase
> Issue Type: Task
> Reporter: Akash Ashok
> Assignee: Akash Ashok
> Priority: Minor
> Fix For: 0.94.0
>
>
> Add a new method isAborted() to the Abortable interface
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
