[
https://issues.apache.org/jira/browse/HBASE-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111010#comment-14111010
]
Hadoop QA commented on HBASE-11797:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12664389/HBASE_11797.patch
against trunk revision .
ATTACHMENT ID: 12664389
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * {@link #batchCallback(List, Object[],
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
+ * contain any {@link org.apache.hadoop.hbase.KeyValue}, as
indicated by {@link Result#isEmpty()}.
+ * {@link
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback#update(byte[],
byte[], Object)}
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.client.TestReplicaWithCluster
org.apache.hadoop.hbase.replication.TestPerTableCFReplication
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
{color:red}-1 core zombie tests{color}. There are 7 zombie test(s):
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService.testAddVisibilityLabelsOnRSRestart(TestVisibilityLabelsWithDefaultVisLabelService.java:106)
at
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels.testVisibilityLabelsOnKillingOfRSContainingLabelsTable(TestVisibilityLabels.java:358)
at
org.apache.hadoop.hbase.ResourceCheckerJUnitListener.testStarted(ResourceCheckerJUnitListener.java:179)
at
org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock.testTimeout(TestZKInterProcessReadWriteLock.java:323)
at
org.apache.hadoop.hbase.mapreduce.TestImportExport.testMetaExport(TestImportExport.java:209)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10588//console
This message is automatically generated.
> Create Table interface to replace HTableInterface
> -------------------------------------------------
>
> Key: HBASE-11797
> URL: https://issues.apache.org/jira/browse/HBASE-11797
> Project: HBase
> Issue Type: Bug
> Reporter: Carter
> Assignee: Carter
> Attachments: HBASE_11797.patch
>
>
> Basically doing this:
> {code}
> interface Table {
> // get, put related stuff
> }
> @Deprecated
> interface HTableInterface extends Table {
> // users are encouraged to use the new Table interface
> }
> class HTable extends Table {
> // all HTable constructors are deprecated
> // Users are not encouraged to see this class
> }
> {code}
> I'm proposing that in this JIRA I move everything from HTableInterface to
> Table except the following:
> * Anything deprecated
> * Anything @InterfaceAudience.Private ({{coprocessorService(...)}} and
> {{batchCoprocessorService(...)}})
--
This message was sent by Atlassian JIRA
(v6.2#6252)
