[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111165#comment-14111165
]
Nick Dimiduk commented on HBASE-11826:
--------------------------------------
Patch is looking good overall. A couple points of cleanup:
- include deprecation annotations on the implementation methods, not just at
the API layer.
- implementation itself should be moved to the non-deprecated method, and the
deprecated APIs should call to the new implementations when appropriate. For
instance {{flush(byte[] tableNameOrRegionName)}} should do any parsing it needs
to do and defer to {{flush(TableName)}} or {{flushRegion(byte[])}} as
appropriate.
> Split each tableOrRegionName admin methods into two targetted methods
> ---------------------------------------------------------------------
>
> Key: HBASE-11826
> URL: https://issues.apache.org/jira/browse/HBASE-11826
> Project: HBase
> Issue Type: Improvement
> Reporter: Carter
> Assignee: Carter
> Attachments: HBASE_11826.patch
>
>
> Purpose of this is two implement [~enis]'s suggestion to strongly type the
> methods that take "tableOrRegionName" as an argument.
> For instance:
> {code}
> void compact(final String tableNameOrRegionName)
> void compact(final byte[] tableNameOrRegionName)
> {code}
> becomes
> {code}
> @Deprecated
> void compact(final String tableNameOrRegionName)
> @Deprecated
> void compact(final byte[] tableNameOrRegionName)
> void compact(TableName table)
> void compactRegion(final byte[] regionName)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
