[
https://issues.apache.org/jira/browse/HBASE-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113452#comment-14113452
]
ramkrishna.s.vasudevan commented on HBASE-11683:
------------------------------------------------
Looks good.
{code}
metricsFlusherWrapper = new MetricsMobStoreFlusherWrapperImpl(store);
metricsFlusher = new MetricsMobStoreFlusher(metricsFlusherWrapper);
{code}
Should be inside the if?
{code}
scanner = scan.isReversed() ? new ReversedMobStoreScanner(this, getScanInfo(),
scan,
targetCols, readPt, metricsScanner) : new MobStoreScanner(this,
getScanInfo(), scan, targetCols, readPt, metricsScanner);
{code}
Introduce a getter in HMobStore for the metrics Scanner and you will not need
to change the constructor. As we are already passing 'this'.
> Metrics for MOB
> ---------------
>
> Key: HBASE-11683
> URL: https://issues.apache.org/jira/browse/HBASE-11683
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jingcheng Du
> Attachments: HBASE-11683-V2.diff, HBASE-11683.diff
>
>
> We need to make sure to capture metrics about mobs.
> Some basic ones include:
> # of mob writes
> # of mob reads
> # avg size of mob (?)
> # mob files
> # of mob compactions / sweeps
--
This message was sent by Atlassian JIRA
(v6.2#6252)
