[ 
https://issues.apache.org/jira/browse/HBASE-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113591#comment-14113591
 ] 

Jingcheng Du commented on HBASE-11683:
--------------------------------------

Thanks Ram for the review and comments!
bq. Should be inside the if?
Right. Will do that.

bq. Introduce a getter in HMobStore for the metrics Scanner and you will not 
need to change the constructor. As we are already passing 'this'
Yes, this will be included in the next patch.

bq. Once compaction is in place I think we would be adding those metrics also. 
I am fine if we can add that even later after the compaction goes in.
Sure, will add the metrics for mob compaction in the next patch.



> Metrics for MOB
> ---------------
>
>                 Key: HBASE-11683
>                 URL: https://issues.apache.org/jira/browse/HBASE-11683
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jingcheng Du
>         Attachments: HBASE-11683-V2.diff, HBASE-11683.diff
>
>
> We need to make sure to capture metrics about mobs.
> Some basic ones include:
> # of mob writes
> # of mob reads
> # avg size of mob (?)
> # mob files
> # of mob compactions / sweeps



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to