[ 
https://issues.apache.org/jira/browse/HBASE-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118453#comment-14118453
 ] 

Jean-Marc Spaggiari commented on HBASE-11878:
---------------------------------------------

Server 1:
{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running 
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.807 sec

Results :

Tests run: 21, Failures: 0, Errors: 0, Skipped: 0
{code}

Server 2:
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] HBase ............................................. SUCCESS [2.637s]
[INFO] HBase - Common .................................... SUCCESS [20.354s]
[INFO] HBase - Protocol .................................. SUCCESS [0.386s]
[INFO] HBase - Client .................................... SUCCESS [37.509s]
[INFO] HBase - Hadoop Compatibility ...................... SUCCESS [5.187s]
[INFO] HBase - Hadoop Two Compatibility .................. SUCCESS [1.533s]
[INFO] HBase - Prefix Tree ............................... SUCCESS [3.687s]
[INFO] HBase - Server .................................... SUCCESS [48:08.762s]
[INFO] HBase - Testing Util .............................. SUCCESS [1.484s]
[INFO] HBase - Thrift .................................... SUCCESS [2:16.690s]
[INFO] HBase - Shell ..................................... SUCCESS [1.120s]
[INFO] HBase - Integration Tests ......................... SUCCESS [1.036s]
[INFO] HBase - Examples .................................. SUCCESS [1.102s]
[INFO] HBase - Assembly .................................. SUCCESS [0.963s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:43.524s
[INFO] Finished at: Tue Sep 02 14:11:43 EDT 2014
[INFO] Final Memory: 48M/626M
[INFO] ------------------------------------------------------------------------
{code}

Server3:
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] HBase ............................................. SUCCESS [2.349s]
[INFO] HBase - Common .................................... SUCCESS [21.581s]
[INFO] HBase - Protocol .................................. SUCCESS [0.352s]
[INFO] HBase - Client .................................... SUCCESS [37.437s]
[INFO] HBase - Hadoop Compatibility ...................... SUCCESS [5.196s]
[INFO] HBase - Hadoop Two Compatibility .................. SUCCESS [1.575s]
[INFO] HBase - Prefix Tree ............................... SUCCESS [3.484s]
[INFO] HBase - Server .................................... SUCCESS [48:28.994s]
[INFO] HBase - Testing Util .............................. SUCCESS [1.441s]
[INFO] HBase - Thrift .................................... SUCCESS [2:13.957s]
[INFO] HBase - Shell ..................................... SUCCESS [1.142s]
[INFO] HBase - Integration Tests ......................... SUCCESS [1.093s]
[INFO] HBase - Examples .................................. SUCCESS [1.120s]
[INFO] HBase - Assembly .................................. SUCCESS [0.945s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52:01.681s
[INFO] Finished at: Tue Sep 02 14:12:01 EDT 2014
[INFO] Final Memory: 46M/543M
[INFO] ------------------------------------------------------------------------
{code}

So v2 passes the tests for me. (Using JDK1.7)

> TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart
>  sometimes fails due to VisibilityController not yet initialized
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11878
>                 URL: https://issues.apache.org/jira/browse/HBASE-11878
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 11878-v1.txt, 11878-v2.txt, 11878-v2.txt
>
>
> In the thread w.r.t. first RC of 0.98.6, 
> http://search-hadoop.com/m/DHED4p2rw81 , Jean-Marc reported that 
> TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart
>  sometimes failed on his machines.
> From 
> http://server.distparser.com:81/hbase/with_teds_patch2/hbasetest1/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay-output.txt
>  :
> {code}
> result {
>   exception {
>     name: "org.apache.hadoop.hbase.coprocessor.CoprocessorException"
>     value: "org.apache.hadoop.hbase.coprocessor.CoprocessorException: 
> VisibilityController not yet initialized\n\tat 
> org.apache.hadoop.hbase.security.visibility.VisibilityController.addLabels(VisibilityController.java:638)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService$1.addLabels(VisibilityLabelsProtos.java:5014)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService.callMethod(VisibilityLabelsProtos.java:5178)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:5794)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1608)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1590)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:30088)\n\tat
>  org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2014)\n\tat 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:98)\n\tat 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:114)\n\tat
>  org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:94)\n\tat 
> java.lang.Thread.run(Thread.java:744)\n"
>   }
> }
> {code}
> The above exception revealed a race condition: writing of labels "ABC" and  
> "XYZ" took place when VisibilityController was not yet initialized.
> The test writes the labels only once, leading to assertion failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to