[ 
https://issues.apache.org/jira/browse/HBASE-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118655#comment-14118655
 ] 

Hadoop QA commented on HBASE-11878:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12665942/11878-v3.txt
  against trunk revision .
  ATTACHMENT ID: 12665942

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.master.TestTableLockManager.testTableReadLock(TestTableLockManager.java:338)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10676//console

This message is automatically generated.

> TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart
>  sometimes fails due to VisibilityController not yet initialized
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11878
>                 URL: https://issues.apache.org/jira/browse/HBASE-11878
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: 11878-v1.txt, 11878-v2.txt, 11878-v2.txt, 11878-v3.txt, 
> 11878-v4.txt
>
>
> In the thread w.r.t. first RC of 0.98.6, 
> http://search-hadoop.com/m/DHED4p2rw81 , Jean-Marc reported that 
> TestVisibilityLabelsWithDistributedLogReplay#testAddVisibilityLabelsOnRSRestart
>  sometimes failed on his machines.
> From 
> http://server.distparser.com:81/hbase/with_teds_patch2/hbasetest1/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay-output.txt
>  :
> {code}
> result {
>   exception {
>     name: "org.apache.hadoop.hbase.coprocessor.CoprocessorException"
>     value: "org.apache.hadoop.hbase.coprocessor.CoprocessorException: 
> VisibilityController not yet initialized\n\tat 
> org.apache.hadoop.hbase.security.visibility.VisibilityController.addLabels(VisibilityController.java:638)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService$1.addLabels(VisibilityLabelsProtos.java:5014)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.VisibilityLabelsProtos$VisibilityLabelsService.callMethod(VisibilityLabelsProtos.java:5178)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:5794)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1608)\n\tat
>  
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1590)\n\tat
>  
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:30088)\n\tat
>  org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2014)\n\tat 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:98)\n\tat 
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:114)\n\tat
>  org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:94)\n\tat 
> java.lang.Thread.run(Thread.java:744)\n"
>   }
> }
> {code}
> The above exception revealed a race condition: writing of labels "ABC" and  
> "XYZ" took place when VisibilityController was not yet initialized.
> The test writes the labels only once, leading to assertion failure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to