[ https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118734#comment-14118734 ]
Hadoop QA commented on HBASE-11805: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665959/HBASE-11805.patch against trunk revision . ATTACHMENT ID: 12665959 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 45 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10681//console This message is automatically generated. > KeyValue to Cell Convert in WALEdit APIs > ---------------------------------------- > > Key: HBASE-11805 > URL: https://issues.apache.org/jira/browse/HBASE-11805 > Project: HBase > Issue Type: Improvement > Components: wal > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 0.99.0, 2.0.0, 0.98.7 > > Attachments: HBASE-11805.patch > > > In almost all other main interface class/APIs we have changed KeyValue to > Cell. But missing in WALEdit. This is public marked for Replication (Well it > should be for CP also) > These 2 APIs deal with KVs > add(KeyValue kv) > ArrayList<KeyValue> getKeyValues() > Suggest deprecate them and add for 0.98 > add(Cell kv) > List<Cell> getCells() > And just replace from 1.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)