[ 
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122481#comment-14122481
 ] 

Anoop Sam John commented on HBASE-11805:
----------------------------------------

My bad. I missed reading that code. Thanks we will have to remove.

Yes to get the adv we must handle the Codec side also.  That is why the 
Umbrella jira I raised (HBASE-11871)  Will check and raise a sub task to use 
the Cells in Codec where we write the WALEdit.

One main intent for this Jira is to change the exposed interface signature to 
use Cell. This has to happen before 1.0 release. WALEdit is exposed to CPs and 
Replication.

Thanks for the review Ram.

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11805.patch, HBASE-11805_0.98.patch, 
> HBASE-11805_V2.patch
>
>
> In almost all other main interface class/APIs we have changed KeyValue to 
> Cell. But missing in WALEdit. This is public marked for Replication (Well it 
> should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to