[
https://issues.apache.org/jira/browse/HBASE-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092794#comment-13092794
]
[email protected] commented on HBASE-4269:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1675/
-----------------------------------------------------------
(Updated 2011-08-29 12:10:51.509870)
Review request for hbase, Ted Yu and Ming Ma.
Changes
-------
Addressed comments
Summary (updated)
-------
commit d2bbee8696d54245b046158bacb5ab1a210e5df6
Author: Jonathan Hsieh <[email protected]>
Date: Sun Aug 28 19:10:57 2011 -0700
HBASE-4269: Add tests and restore semantics to
TableInputFormat/TableRecordReader
Adding tests cases and restoring sematics from HBASE-4196 patch.
This addresses bug HBASE-4269.
https://issues.apache.org/jira/browse/HBASE-4269
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java
c5fc496
src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
54df2cf
Diff: https://reviews.apache.org/r/1675/diff
Testing
-------
New unit tests pass, running other tests.
Thanks,
jmhsieh
> Add tests and restore semantics to TableInputFormat/TableRecordReader
> ---------------------------------------------------------------------
>
> Key: HBASE-4269
> URL: https://issues.apache.org/jira/browse/HBASE-4269
> Project: HBase
> Issue Type: Improvement
> Components: mapred, mapreduce, test
> Affects Versions: 0.92.0, 0.90.5
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.5
>
> Attachments:
> 0001-HBASE-4269-Add-tests-and-restore-semantics-to-TableI.patch
>
>
> HBASE-4196 Modified the semantics of failures in
> TableImportFormat/TableRecordReader, and had no tests cases. This patch
> restores semantics to rethrow when a DoNotRetryIOException is triggered and
> adds test cases.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira