[ https://issues.apache.org/jira/browse/HBASE-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093082#comment-13093082 ]
jirapos...@reviews.apache.org commented on HBASE-4269: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1675/#review1682 ----------------------------------------------------------- Ship it! +1 nit: test is excellent but looks like could have gone into TestTableInputFormatScan? Lets commit. - Michael On 2011-08-29 12:10:51, jmhsieh wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1675/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-08-29 12:10:51) bq. bq. bq. Review request for hbase, Ted Yu and Ming Ma. bq. bq. bq. Summary bq. ------- bq. bq. commit d2bbee8696d54245b046158bacb5ab1a210e5df6 bq. Author: Jonathan Hsieh <j...@cloudera.com> bq. Date: Sun Aug 28 19:10:57 2011 -0700 bq. bq. HBASE-4269: Add tests and restore semantics to TableInputFormat/TableRecordReader bq. bq. Adding tests cases and restoring sematics from HBASE-4196 patch. bq. bq. bq. This addresses bug HBASE-4269. bq. https://issues.apache.org/jira/browse/HBASE-4269 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java c5fc496 bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableInputFormat.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java 54df2cf bq. bq. Diff: https://reviews.apache.org/r/1675/diff bq. bq. bq. Testing bq. ------- bq. bq. New unit tests pass, running other tests. bq. bq. bq. Thanks, bq. bq. jmhsieh bq. bq. > Add tests and restore semantics to TableInputFormat/TableRecordReader > --------------------------------------------------------------------- > > Key: HBASE-4269 > URL: https://issues.apache.org/jira/browse/HBASE-4269 > Project: HBase > Issue Type: Improvement > Components: mapred, mapreduce, test > Affects Versions: 0.92.0, 0.90.5 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Fix For: 0.90.5 > > Attachments: > 0001-HBASE-4269-Add-tests-and-restore-semantics-to-TableI.patch, > 0001-HBASE-4269-Add-tests-and-restore-semantics-to-TableI.patch > > > HBASE-4196 Modified the semantics of failures in > TableImportFormat/TableRecordReader, and had no tests cases. This patch > restores semantics to rethrow when a DoNotRetryIOException is triggered and > adds test cases. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira