[ 
https://issues.apache.org/jira/browse/HBASE-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126346#comment-14126346
 ] 

Hadoop QA commented on HBASE-11911:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12667239/HBASE-11911-preview.patch
  against trunk revision .
  ATTACHMENT ID: 12667239

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1920 
new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    + * Tag a test as related to the client, This tests the hbase-client 
package and all of the client tests in
+@Category({RPCTests.class, MediumTests.class})   // Can't be small, we're 
playing with the EnvironmentEdge
+  public void 
testRSTerminationAfterRegisteringToMasterBeforeCreatingEphemeralNod() throws 
Exception {
+            <argLine>-enableassertions -XX:MaxDirectMemorySize=1G -Xmx1024m 
-XX:MaxPermSize=256m -Djava.security.egd=file:/dev/./urandom 
-Djava.net.preferIPv4Stack=true -Djava.awt.headless=true</argLine>
+    
<surefire.firstPartGroups>org.apache.hadoop.hbase.testclassification.SmallTests</surefire.firstPartGroups>
+    
<surefire.secondPartGroups>org.apache.hadoop.hbase.testclassification.MediumTests</surefire.secondPartGroups>
+                <argLine>-enableassertions -Xmx1900m -XX:MaxPermSize=256m 
-Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true 
"-Djava.library.path=${hadoop.library.path};${java.library.path}"
+          
org.apache.hadoop.hbase.testclassification.MediumTests,org.apache.hadoop.hbase.testclassification.LargeTests

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestRegionRebalancing

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10742//console

This message is automatically generated.

> Break up tests into more fine grained categories
> ------------------------------------------------
>
>                 Key: HBASE-11911
>                 URL: https://issues.apache.org/jira/browse/HBASE-11911
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Alex Newman
>            Assignee: Alex Newman
>         Attachments: HBASE-11911-preview.patch, HBASE-11911-v0.patch
>
>
> Wouldn't it be nice to run all of the client tests (client and the ones in 
> hbase-server)  in a single command like.
> mvn test -PrunClientTests
> how about all of the small tests not having to do with mapReduce
> mvn test -PrunSmallTests,!runMapReduceTests
> how about breaking up the build into small pieces so it can be run on travis 
> or circle-ci. If that's what you are into, +1 this patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to