[
https://issues.apache.org/jira/browse/HBASE-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131897#comment-14131897
]
Enis Soztutar commented on HBASE-11825:
---------------------------------------
Thanks Solomon, Carter for working on this.
Can you please change below to be Connection#getTable(). I think in my original
patch, I started with Connection#createTable() and Connection#createAdmin()
instead of getTable(), but changed it because createTable() is creating a
Table.java object rather than creating an actual table for data, ie
Admin.createTable().
{code}
+ * From this {@link Connection} {@link Table} implementations are retrieved
+ * with {@link Connection#createTable(byte[])}. Example:
{code}
bq. Admin.getConnection() returns a Connection and HBaseAdmin.getConnection()
returns an HConnection.
This is good. Will keep BC. Admin is a new interface.
maybe remove this line:
{code}
+ * listTables() kind of methods should be delegated to admin? TODO
{code}
bq. I had to revert some of the Admin -> HBaseAdmin changes after I changed
Admin's getConnection method to return a Connection instead of an HConnection
Ok, this should be fine for now.
This is pretty important. I would love the other devs to take a look as well.
> Create Connection and ConnectionManager
> ---------------------------------------
>
> Key: HBASE-11825
> URL: https://issues.apache.org/jira/browse/HBASE-11825
> Project: HBase
> Issue Type: Improvement
> Reporter: Carter
> Assignee: Solomon Duskis
> Priority: Critical
> Fix For: 2.0.0, 0.99.1
>
> Attachments: HBASE_11825.patch
>
>
> This is further cleanup of the HBase interface for 1.0 after implementing the
> new Table and Admin interfaces. Following Enis's guidelines in HBASE-10602,
> this JIRA will generate a new ConnectionManager to replace HCM and Connection
> to replace HConnection.
> For more detail, this JIRA intends to implement this portion:
> {code}
> interface Connection extends Closeable{
> Table getTable(), and rest of HConnection methods
> getAdmin()
> // no deprecated methods (cache related etc)
> }
> @Deprecated
> interface HConnection extends Connection {
> @Deprecated
> HTableInterface getTable()
> // users are encouraged to use Connection
> }
> class ConnectionManager {
> createConnection(Configuration) // not sure whether we want a static
> factory method to create connections or a ctor
> }
> @Deprecated
> class HCM extends ConnectionManager {
> // users are encouraged to use ConnectionManager
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
