[
https://issues.apache.org/jira/browse/HBASE-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134655#comment-14134655
]
Enis Soztutar commented on HBASE-11825:
---------------------------------------
This looks good to commit. But my vote won't count for this patch.
[~lhofhansl] do you need time to check this out? I want to get this in for
0.99.0RC1.
I think isClosed() is fine. We can make close() idempotent and also have
isClosed(), no? Just document that close() is idempotent in javadoc. From
HConnectionImpl, it seems that it is already the case.
> Create Connection and ConnectionManager
> ---------------------------------------
>
> Key: HBASE-11825
> URL: https://issues.apache.org/jira/browse/HBASE-11825
> Project: HBase
> Issue Type: Improvement
> Reporter: Carter
> Assignee: Solomon Duskis
> Priority: Critical
> Fix For: 2.0.0, 0.99.1
>
> Attachments: HBASE_11825.patch, HBASE_11825_v1.patch
>
>
> This is further cleanup of the HBase interface for 1.0 after implementing the
> new Table and Admin interfaces. Following Enis's guidelines in HBASE-10602,
> this JIRA will generate a new ConnectionManager to replace HCM and Connection
> to replace HConnection.
> For more detail, this JIRA intends to implement this portion:
> {code}
> interface Connection extends Closeable{
> Table getTable(), and rest of HConnection methods
> getAdmin()
> // no deprecated methods (cache related etc)
> }
> @Deprecated
> interface HConnection extends Connection {
> @Deprecated
> HTableInterface getTable()
> // users are encouraged to use Connection
> }
> class ConnectionManager {
> createConnection(Configuration) // not sure whether we want a static
> factory method to create connections or a ctor
> }
> @Deprecated
> class HCM extends ConnectionManager {
> // users are encouraged to use ConnectionManager
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
