[
https://issues.apache.org/jira/browse/HBASE-12090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149613#comment-14149613
]
Ted Yu commented on HBASE-12090:
--------------------------------
I would say that beautiful code has to be code that works :-)
+1
There're several places where formatting for if statement should be adjusted.
e.g.
{code}
+ if( minLength - offset >= SIZEOF_INT){
{code}
Put a space between if and (, remove the space following (, add a space between
) and {.
> Bytes: more Unsafe, more Faster
> --------------------------------
>
> Key: HBASE-12090
> URL: https://issues.apache.org/jira/browse/HBASE-12090
> Project: HBase
> Issue Type: Improvement
> Components: Performance
> Affects Versions: 0.94.23, 0.98.6
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0, 0.98.7, 0.94.24, 0.99.1
>
> Attachments: 12090-v1.1.txt, HBASE-12090.patch
>
>
> Additional optimizations to *org.apache.hadoop.hbase.util.Bytes*:
> * New version of compareTo method.
> * New versions for primitive converters : putXXX/toXXX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
