[ https://issues.apache.org/jira/browse/HBASE-12187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170285#comment-14170285 ]
Ding Yuan commented on HBASE-12187: ----------------------------------- Hi Stack and Andrew, It seems from the discussion of HBASE-11912 you guys think error-prone might be a better approach, then I will try to add a few checks into error-prone to catch the trivial bug patterns implemented by aspirator. I am not familiar with error-prone's AST representation, so I am not sure whether some of the checks can be easily implemented, but it shouldn't be complicated anyway. Afterward I can also try to provide a FindBugs implementation. Do you guys have your own error-prone repository or I should simply work on the one from https://code.google.com/p/error-prone/? cheers, > Review in source the paper "Simple Testing Can Prevent Most Critical Failures" > ------------------------------------------------------------------------------ > > Key: HBASE-12187 > URL: https://issues.apache.org/jira/browse/HBASE-12187 > Project: HBase > Issue Type: Bug > Reporter: stack > Priority: Critical > > Review the helpful paper > https://www.usenix.org/system/files/conference/osdi14/osdi14-paper-yuan.pdf > It describes 'catastrophic failures', especially issues where exceptions are > thrown but not properly handled. Their static analysis tool Aspirator turns > up a bunch of the obvious offenders (Lets add to test-patch.sh alongside > findbugs?). This issue is about going through code base making sub-issues to > root out these and others (Don't we have the test described in figure #6 > already? I thought we did? If we don't, need to add). -- This message was sent by Atlassian JIRA (v6.3.4#6332)