[ 
https://issues.apache.org/jira/browse/HBASE-12161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171589#comment-14171589
 ] 

Ted Yu commented on HBASE-12161:
--------------------------------

lgtm
{code}
        TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl");
{code}
Referring to AccessControlConstants#OP_ATTRIBUTE_ACL would be better.
{code}
          public void testAccessControlClientGrantRevokeOnNameSpace() throws 
Exception {
{code}
nit: 'Namespace' (lower case s) should suffice.

> Add support for grant/revoke on namespaces in AccessControlClient
> -----------------------------------------------------------------
>
>                 Key: HBASE-12161
>                 URL: https://issues.apache.org/jira/browse/HBASE-12161
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-12161_0.98.patch, HBASE-12161_master.patch, 
> HBASE-12161_master_v2.patch
>
>
> As per the description.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to