[ 
https://issues.apache.org/jira/browse/HBASE-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171948#comment-14171948
 ] 

Anoop Sam John commented on HBASE-12202:
----------------------------------------

The null checks and others I can remove. Agree with you.
It can work with offheap within this class. But an e2e test can be possible 
only after we do similar work in other read flow areas. Me and Ram working on 
those already. 
Like the above checks they are there in BB impls. Andy used to share concerns 
over this wrt perf. Also these can result in code not getting inlined. BB to BR 
change was ib that regard so that we can have own simplied impls of BB which is 
backed by BR (?) Any way those area will touch after these changes.
Thanks boss

> Support DirectByteBuffer usage in HFileBlock
> --------------------------------------------
>
>                 Key: HBASE-12202
>                 URL: https://issues.apache.org/jira/browse/HBASE-12202
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 0.99.2
>
>         Attachments: HBASE-12202.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to