[
https://issues.apache.org/jira/browse/HBASE-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174388#comment-14174388
]
stack commented on HBASE-12075:
-------------------------------
bq. It was very subtle.
Sorry about that [~manukranthk] We should deprecate and do a new mocked
connection using the new Connection Interface...
Looking at the patch:
Why 'new' in getNewRpcRetryingCallerFactory? Why not just
getRpcRetryingCallerFactory?
ClusterConnection is internal? Not exposed?
We owe you a more thorough review (I am out of time at mo... ) Will be back.
This is a load of new code. Others interested in client interaction should
take a look too.....
> Preemptive Fast Fail
> --------------------
>
> Key: HBASE-12075
> URL: https://issues.apache.org/jira/browse/HBASE-12075
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 0.99.0, 2.0.0, 0.98.6.1
> Reporter: Manukranth Kolloju
> Assignee: Manukranth Kolloju
> Attachments: 0001-Add-a-test-case-for-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch
>
>
> In multi threaded clients, we use a feature developed on 0.89-fb branch
> called Preemptive Fast Fail. This allows the client threads which would
> potentially fail, fail fast. The idea behind this feature is that we allow,
> among the hundreds of client threads, one thread to try and establish
> connection with the regionserver and if that succeeds, we mark it as a live
> node again. Meanwhile, other threads which are trying to establish connection
> to the same server would ideally go into the timeouts which is effectively
> unfruitful. We can in those cases return appropriate exceptions to those
> clients instead of letting them retry.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
