[
https://issues.apache.org/jira/browse/HBASE-12075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184416#comment-14184416
]
Manukranth Kolloju commented on HBASE-12075:
--------------------------------------------
I can add some simpler example illustrating what we can do, in the release
notes. The NoOpRetryableCallerInterceptor will be used by default. The client
behavior by default doesn't change. As long as
hbase.client.enable.fast.fail.mode is set to false, the code will use the
NoOpInterceptor.
About the "new" in the getNewRpcRetryingCallerFactory, I too felt that it
didn't sound so much like a builder method. On the contrary I didn't
particularly like (create/build)RpcRetryingCallerFactory either. I didn't have
a specific choice about it and left it like that and commented the same on the
diff. I can make the classes which I am not using in the server tests as
package private.
> Preemptive Fast Fail
> --------------------
>
> Key: HBASE-12075
> URL: https://issues.apache.org/jira/browse/HBASE-12075
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 0.99.0, 2.0.0, 0.98.6.1
> Reporter: Manukranth Kolloju
> Assignee: Manukranth Kolloju
> Attachments: 0001-Add-a-test-case-for-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-HBASE-12075-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch,
> 0001-Implement-Preemptive-Fast-Fail.patch
>
>
> In multi threaded clients, we use a feature developed on 0.89-fb branch
> called Preemptive Fast Fail. This allows the client threads which would
> potentially fail, fail fast. The idea behind this feature is that we allow,
> among the hundreds of client threads, one thread to try and establish
> connection with the regionserver and if that succeeds, we mark it as a live
> node again. Meanwhile, other threads which are trying to establish connection
> to the same server would ideally go into the timeouts which is effectively
> unfruitful. We can in those cases return appropriate exceptions to those
> clients instead of letting them retry.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
