[ 
https://issues.apache.org/jira/browse/HBASE-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100099#comment-13100099
 ] 

Lars Hofhansl commented on HBASE-2195:
--------------------------------------

HLogKey.version is still static, v13 won't work.
This is supposed to be the static version of the *class*, not the instance.

I maintain that the version check in readAllEntriesToReplicateOrNextFile() is 
neither needed nor (IMHO) desired.

On the good side if we quibbling over this detail the rest of the patch seems 
to be OK :)


> Support cyclic replication
> --------------------------
>
>                 Key: HBASE-2195
>                 URL: https://issues.apache.org/jira/browse/HBASE-2195
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>            Reporter: Jean-Daniel Cryans
>            Assignee: Lars Hofhansl
>         Attachments: 2195-v10.txt, 2195-v12.txt, 2195-v13.txt, 2195-v5.txt, 
> 2195-v6.txt, 2195.txt
>
>
> We need to support cyclic replication by using the cluster id of each HlogKey 
> and stop replicating when it goes back to the original cluster.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to