[ 
https://issues.apache.org/jira/browse/HBASE-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185431#comment-14185431
 ] 

Hadoop QA commented on HBASE-12348:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12677312/HBASE-12348.patch
  against trunk revision .
  ATTACHMENT ID: 12677312

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestHCM

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11475//console

This message is automatically generated.

> Add family name in audit log for addColumn, deleteColumn  and modifyColumn 
> operations
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-12348
>                 URL: https://issues.apache.org/jira/browse/HBASE-12348
>             Project: HBase
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.98.5
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>         Attachments: HBASE-12348.patch
>
>
> Family name can be added in audit log for addColumn, deleteColumn  and 
> modifyColumn operations similar to createTable operation.
> {noformat}
> create 't', 'd'
> 2014-10-27 20:41:54,303 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user ashish; reason: Global check allowed; remote address: 
> /10.18.40.106; request: createTable; context: (user=ashish, scope=t, 
> family=d, action=CREATE)
> alter 't', NAME => 'd', VERSIONS => 5
> 2014-10-27 20:42:54,771 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user ashish; reason: Table permission granted; remote 
> address: /10.18.40.106; request: modifyColumn; context: (user=ashish, 
> scope=t, family=, action=ADMIN)
> alter 't', 'd2'
> 2014-10-27 20:44:45,635 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user ashish; reason: Table permission granted; remote 
> address: /10.18.40.106; request: addColumn; context: (user=ashish, scope=t, 
> family=, action=ADMIN)
> alter 't', NAME => 'd2', METHOD => 'delete'
> 2014-10-27 20:45:25,681 TRACE 
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController: 
> Access allowed for user ashish; reason: Table permission granted; remote 
> address: /10.18.40.106; request: deleteColumn; context: (user=ashish, 
> scope=t, family=, action=ADMIN)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to