[
https://issues.apache.org/jira/browse/HBASE-12348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186616#comment-14186616
]
Ashish Singhi commented on HBASE-12348:
---------------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
{quote}
Not added any UT as it was only log change.
{quote}
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestHCM
{quote}
Not related to patch. Raised HBASE-12357 to track the same.
> Add family name in audit log for addColumn, deleteColumn and modifyColumn
> operations
> -------------------------------------------------------------------------------------
>
> Key: HBASE-12348
> URL: https://issues.apache.org/jira/browse/HBASE-12348
> Project: HBase
> Issue Type: Improvement
> Components: security
> Affects Versions: 0.98.5
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Priority: Minor
> Attachments: HBASE-12348.patch
>
>
> Family name can be added in audit log for addColumn, deleteColumn and
> modifyColumn operations similar to createTable operation.
> {noformat}
> create 't', 'd'
> 2014-10-27 20:41:54,303 TRACE
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController:
> Access allowed for user ashish; reason: Global check allowed; remote address:
> /10.18.40.106; request: createTable; context: (user=ashish, scope=t,
> family=d, action=CREATE)
> alter 't', NAME => 'd', VERSIONS => 5
> 2014-10-27 20:42:54,771 TRACE
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController:
> Access allowed for user ashish; reason: Table permission granted; remote
> address: /10.18.40.106; request: modifyColumn; context: (user=ashish,
> scope=t, family=, action=ADMIN)
> alter 't', 'd2'
> 2014-10-27 20:44:45,635 TRACE
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController:
> Access allowed for user ashish; reason: Table permission granted; remote
> address: /10.18.40.106; request: addColumn; context: (user=ashish, scope=t,
> family=, action=ADMIN)
> alter 't', NAME => 'd2', METHOD => 'delete'
> 2014-10-27 20:45:25,681 TRACE
> SecurityLogger.org.apache.hadoop.hbase.security.access.AccessController:
> Access allowed for user ashish; reason: Table permission granted; remote
> address: /10.18.40.106; request: deleteColumn; context: (user=ashish,
> scope=t, family=, action=ADMIN)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
