[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188422#comment-14188422
]
Niels Basjes commented on HBASE-12279:
--------------------------------------
The patch I created for HBASE-12272 includes an explicit check that the
configured version is actually used.
So as long as the pom.xml says "<thrift.version>0.9.0</thrift.version>" trying
it with 0.9.1 will fail, which is exactly the check we need here.
As far as I can tell the HBASE-12272 patch should also work quite nicely on the
older HBase where thrift 0.8.0 is still needed.
> Generated thrift files were generated with the wrong parameters
> ---------------------------------------------------------------
>
> Key: HBASE-12279
> URL: https://issues.apache.org/jira/browse/HBASE-12279
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.98.0, 0.99.0
> Reporter: Niels Basjes
> Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
>
> Attachments: HBASE-12279-2014-10-16-v1.patch
>
>
> It turns out that the java code generated from the thrift files have been
> generated with the wrong settings.
> Instead of the documented
> ([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
>
> [thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
>
> {code}
> thrift -strict --gen java:hashcode
> {code}
> the current files seem to be generated instead with
> {code}
> thrift -strict --gen java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
