[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203080#comment-14203080
]
Andrew Purtell commented on HBASE-12279:
----------------------------------------
'mvn generate-sources -Pcompile-thrift' works for 0.98 and higher. We are
missing this for 0.94. I regenerated files for 0.94 using version 0.8.0 of the
compiler by hand.
Regenerated Thrift for 0.98+ with compiler "Thrift version 0.9.0"
*0.98 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 68.372 sec
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.219 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.955 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.931 sec
Results :
Tests run: 59, Failures: 0, Errors: 0, Skipped: 0
{noformat}
*branch-1 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 60.84 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.037 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServer
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.799 sec -
in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.776 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Results :
Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
{noformat}
*master tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.82 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.724 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServer
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.98 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.261 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Results :
Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
{noformat}
Regenerated Thrift for 0.94 with compiler "Thrift version 0.8.0". Built this
version of the compiler from the Thrift 0.8.0 distribution tarball downloaded
from archive.apache.org.
*0.94 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 317.191 sec
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.331 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.159 sec
Results :
Tests run: 40, Failures: 0, Errors: 0, Skipped: 0
{noformat}
Going to commit 0.98+ shortly unless objection.
Going to commit 0.94 over the weekend probably, ping [~lhofhansl]
> Generated thrift files were generated with the wrong parameters
> ---------------------------------------------------------------
>
> Key: HBASE-12279
> URL: https://issues.apache.org/jira/browse/HBASE-12279
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0, 0.98.0, 0.99.0
> Reporter: Niels Basjes
> Assignee: Niels Basjes
> Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
>
> Attachments: HBASE-12279-2014-10-16-v1.patch,
> HBASE-12279-2014-11-07-v2.patch
>
>
> It turns out that the java code generated from the thrift files have been
> generated with the wrong settings.
> Instead of the documented
> ([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
>
> [thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
>
> {code}
> thrift -strict --gen java:hashcode
> {code}
> the current files seem to be generated instead with
> {code}
> thrift -strict --gen java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
