[ 
https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190213#comment-14190213
 ] 

Sean Busbey commented on HBASE-12272:
-------------------------------------

Sorry for the late feedback, but something just occurred to me. We know that 
there are issues changing thrift versions and that we have made releases with 
particular versions in place. As things currently stand, the version can be 
changed at compile time because thrift.version is a property. It's probably a 
good idea to add a rule for the maven enforcer plugin that fixes the property 
to 0.9.0 (or whatever version a given release line is based on) with a note 
that setting it to something else needs to be reviewed for wire and behavior 
compatibility.

> Generate Thrift code through maven
> ----------------------------------
>
>                 Key: HBASE-12272
>                 URL: https://issues.apache.org/jira/browse/HBASE-12272
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, documentation, Thrift
>            Reporter: Niels Basjes
>             Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
>
>         Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch, 
> HBASE-12272-2014-10-16-v2.patch, HBASE-12272-2014-10-16-v3.patch, 
> HBASE-12272-2014-10-16-v4.patch
>
>
> The generated thrift code is currently under source control, but the 
> instructions on rebuilding it is buried in package javadocs.
> We should have a simple maven command to rebuild them, similar to what we 
> have for protobufs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to