[ https://issues.apache.org/jira/browse/HBASE-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14198521#comment-14198521 ]
Niels Basjes commented on HBASE-12272: -------------------------------------- [~busbey] The new patch should work now. I didn't touch this test that failed. Seems like an existing problem in the master. I'm still a bit baffled why the [~hadoopqa] didn't fail my previous patch yesterday with the obvious merge conflicts that were present. > Generate Thrift code through maven > ---------------------------------- > > Key: HBASE-12272 > URL: https://issues.apache.org/jira/browse/HBASE-12272 > Project: HBase > Issue Type: Improvement > Components: build, documentation, Thrift > Reporter: Niels Basjes > Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2 > > Attachments: HBASE-12272-2014-10-15-v1-PREVIEW.patch, > HBASE-12272-2014-10-16-v2.patch, HBASE-12272-2014-10-16-v3.patch, > HBASE-12272-2014-10-16-v4.patch, HBASE-12272-2014-11-04-v5.patch, > HBASE-12272-2014-11-05-v5.patch > > > The generated thrift code is currently under source control, but the > instructions on rebuilding it is buried in package javadocs. > We should have a simple maven command to rebuild them, similar to what we > have for protobufs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)