[ 
https://issues.apache.org/jira/browse/HBASE-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216980#comment-14216980
 ] 

Hudson commented on HBASE-12517:
--------------------------------

FAILURE: Integrated in HBase-TRUNK #5788 (See 
[https://builds.apache.org/job/HBase-TRUNK/5788/])
HBASE-12517 Ensure HConstants members are final. (stack: rev 
14dc08c07f2c47fd7dae59ae1a7e558e1324e300)
* hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java


> Several HConstant members are assignable
> ----------------------------------------
>
>                 Key: HBASE-12517
>                 URL: https://issues.apache.org/jira/browse/HBASE-12517
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>              Labels: beginner, checkstyle
>             Fix For: 2.0.0, 0.98.9, 0.99.2
>
>         Attachments: HBASE-12517.1.patch.txt
>
>
> Several of the members in HConstants are not marked final.
> Generate up-to-date list with command:
> 0.98+
> {code}
> for line in "`grep -e '^ *public' 
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v 
> final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> 0.94:
> {code}
> for line in "`grep -e '^ *public' 
> src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v final`"; do 
> echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> These mutable versions have been in many releases. We correctly don't assign 
> to them in our codebase, but there's no way to know if anyone does downstream.
> HConstants is IA.Public and IS.Stable, but I'm fairly certain this behavior 
> was unintentional and there isn't a non-broken use for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to