[
https://issues.apache.org/jira/browse/HBASE-12517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217220#comment-14217220
]
Hudson commented on HBASE-12517:
--------------------------------
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #649 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/649/])
HBASE-12517 Ensure HConstants members are final. (stack: rev
7067f31e079258ab1154ed1b0c2f692ac3604634)
* hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
> Several HConstant members are assignable
> ----------------------------------------
>
> Key: HBASE-12517
> URL: https://issues.apache.org/jira/browse/HBASE-12517
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Labels: beginner, checkstyle
> Fix For: 2.0.0, 0.98.9, 0.99.2
>
> Attachments: HBASE-12517.1.patch.txt
>
>
> Several of the members in HConstants are not marked final.
> Generate up-to-date list with command:
> 0.98+
> {code}
> for line in "`grep -e '^ *public'
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v
> final`"; do echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> 0.94:
> {code}
> for line in "`grep -e '^ *public'
> src/main/java/org/apache/hadoop/hbase/HConstants.java | grep -v final`"; do
> echo "${line}" | grep -o -e " [A-Z_][A-Z_]* "; done
> {code}
> These mutable versions have been in many releases. We correctly don't assign
> to them in our codebase, but there's no way to know if anyone does downstream.
> HConstants is IA.Public and IS.Stable, but I'm fairly certain this behavior
> was unintentional and there isn't a non-broken use for it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
