[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217202#comment-14217202
]
Andrew Purtell edited comment on HBASE-12373 at 11/19/14 1:18 AM:
------------------------------------------------------------------
+1 in general for the change for 0.98 (if you are planning a 0.98 patch
[~jerryhe]), this patch only adds new APIs in VisibilityClient and a new shell
command.
Comments on the patch:
Is it safe to assume the labels table will always only have one region?
Related, have you given any thought to the many thousands of labels use case?
(Or [~busbey] was challenging us to think (eventually) of millions of labels.)
Would it be wise to marshall up ~thousands of results in one
ListLabelsResponse? Probably not, that would be a fat RPC. Also, the shell
command would only be useful then with an optional parameter supplying a regex
expected to bound the result set to a reasonable amount. I think these
considerations suggest instead doing a scan over the labels table directly from
code in VisibilityClient. That scan should be able to push down a regex filter.
I realize this makes indirection through the visibility label service more
"interesting". The service impl would need to supply a client piece for listing
labels.
was (Author: apurtell):
+1 in general for the change for 0.98 (if you are planning a 0.98 patch
[~jerryhe]), this patch only adds new APIs in VisibilityClient and a new shell
command.
Comments on the patch:
Is it safe to assume the labels table will always only have one region?
Related, have you given any thought to the many thousands of labels use case?
(Or [~busbey] was challenging us to think (eventually) of millions of labels.)
Would it be wise to marshall up ~thousands of results in one
ListLabelsResponse? Probably not, that would be a fat RPC. Also, the shell
command would only be useful then with an optional parameter supplying a regex
expected to bound the result set to a reasonable amount. I think these
considerations suggest instead doing a scan over the labels table directly from
code in VisibilityClient. I realize this makes indirection through the
visibility label service more "interesting". The service impl would need to
supply a client piece for listing labels.
> Provide a command to list visibility labels
> -------------------------------------------
>
> Key: HBASE-12373
> URL: https://issues.apache.org/jira/browse/HBASE-12373
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.98.7, 0.99.1
> Reporter: Jerry He
> Assignee: Jerry He
> Priority: Minor
> Fix For: 0.98.9, 0.99.2
>
> Attachments: HBASE-12373-master-v2.patch,
> HBASE-12373-master-v3.patch, HBASE-12373-master.patch
>
>
> A command to list visibility labels that are in place would be handy.
> This is also in line with many of the other hbase list commands.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
