[
https://issues.apache.org/jira/browse/HBASE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103216#comment-13103216
]
[email protected] commented on HBASE-4322:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1789/#review1865
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4267>
this not is not the english :)
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4268>
we already checked the first part of this condition above, right? seems
redundant.
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4269>
I think this should be >= -- a region with equal start and end key is
invalid, right?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4270>
this type is really a SortedSet<byte[]> right?
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4271>
indent
src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
<https://reviews.apache.org/r/1789/#comment4272>
what if the last region is missing? ie the highest region in the table has
an endKey that's not EMPTY?
- Todd
On 2011-09-12 01:33:40, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-12 01:33:40)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This requires HBASE-4321.
bq.
bq. commit 0ed6be1b628f3c030480164af37825702a2d5020
bq. Author: Jonathan Hsieh <[email protected]>
bq. Date: Mon Sep 5 02:16:32 2011 -0700
bq.
bq. HBASE-4322 [hbck] Update checkIntegrity/checkRegionChain to present
more accurate region split problem summary
bq.
bq. Minor semantics change
bq. - if two regions overlap this counts as two inconsistencies instead of
one. If three overlap, it counts as three.
bq. - testMetaHole was previously actually was an overlap ([D,E] overlaps
[C,]). Change to make true hole.
bq.
bq.
bq. This addresses bug HBASE-4322.
bq. https://issues.apache.org/jira/browse/HBASE-4322
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 1a704f6
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f42a87c
bq.
bq. Diff: https://reviews.apache.org/r/1789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified unit test passes. Currently running full suite.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> [hbck] Update checkIntegrity/checkRegionChain to present more accurate region
> split problem summary
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-4322
> URL: https://issues.apache.org/jira/browse/HBASE-4322
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.94.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments:
> 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.patch
>
>
> This is a mostly semantics preserving upgrade to hbck that uses the
> RegionSplitCalculator from HBASE-4321 that provides more in depth information
> about region split problems in meta when running hbck.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
