[
https://issues.apache.org/jira/browse/HBASE-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103270#comment-13103270
]
[email protected] commented on HBASE-4322:
------------------------------------------------------
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 623
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line623>
bq. >
bq. > this type is really a SortedSet<byte[]> right?
yes
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 584
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line584>
bq. >
bq. > this not is not the english :)
if no the absolute end key, check for cycle.
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, lines 630-632
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line630>
bq. >
bq. > indent
fixed
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 585
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line585>
bq. >
bq. > we already checked the first part of this condition above, right?
seems redundant.
previous line was bug -- if absolute end key that it is ok to just add. We can
then remove this line as you suggest.
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 586
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line586>
bq. >
bq. > I think this should be >= -- a region with equal start and end key
is invalid, right?
My goal was to be semantics preserving here (even if they are wrong). I'll
file a follow-on jira for this. (HBASE-4378)
bq. On 2011-09-13 00:36:31, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 700
bq. > <https://reviews.apache.org/r/1789/diff/1/?file=40074#file40074line700>
bq. >
bq. > what if the last region is missing? ie the highest region in the
table has an endKey that's not EMPTY?
This test was broken before and endkey region missing wasn't supported either.
Changing test to make this truly correct and will fix in follow on jira.
(HBASE-4379)
- jmhsieh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1789/#review1865
-----------------------------------------------------------
On 2011-09-13 01:56:43, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1789/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-13 01:56:43)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This requires HBASE-4321.
bq.
bq. commit 0ed6be1b628f3c030480164af37825702a2d5020
bq. Author: Jonathan Hsieh <[email protected]>
bq. Date: Mon Sep 5 02:16:32 2011 -0700
bq.
bq. HBASE-4322 [hbck] Update checkIntegrity/checkRegionChain to present
more accurate region split problem summary
bq.
bq. Minor semantics change
bq. - if two regions overlap this counts as two inconsistencies instead of
one. If three overlap, it counts as three.
bq. - testMetaHole was previously actually was an overlap ([D,E] overlaps
[C,]). Change to make true hole.
bq.
bq.
bq. This addresses bug HBASE-4322.
bq. https://issues.apache.org/jira/browse/HBASE-4322
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 1a704f6
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java f42a87c
bq.
bq. Diff: https://reviews.apache.org/r/1789/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified unit test passes. Currently running full suite.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> [hbck] Update checkIntegrity/checkRegionChain to present more accurate region
> split problem summary
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-4322
> URL: https://issues.apache.org/jira/browse/HBASE-4322
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4, 0.94.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments:
> 0001-HBASE-4322-hbck-Update-checkIntegrity-checkRegionCha.patch
>
>
> This is a mostly semantics preserving upgrade to hbck that uses the
> RegionSplitCalculator from HBASE-4321 that provides more in depth information
> about region split problems in meta when running hbck.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
